Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1871] Should not be able to crossbuy after issuing shares #11352

Conversation

philcampeau
Copy link
Collaborator

@philcampeau philcampeau commented Nov 15, 2024

Fixes #10069

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

According to the rules of the game, a company cannot cross-buy after issuing shares. This prevents that from happening.

Screenshots

Any Assumptions / Hacks

Any games where a cross-buy has occurred after issuing shares would need to be pinned or archived.

@philcampeau philcampeau added the pins PR that will require some games to be pinned label Nov 15, 2024
@ollybh ollybh added the 1871 label Dec 15, 2024
@ollybh ollybh merged commit 4d661ea into tobymao:master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1871 pins PR that will require some games to be pinned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[The Old Prince-1871] Forced Train Purchase allows you to Cross buy (incorrectly)
2 participants