[1849] fix for the Bonds variant

[philcampeau]

Fixes #11138

(hopefully)

Before clicking "Create"

• Branch is derived from the latest master
• Add the pins or archive_alpha_games label if this change will break existing games
• Code passes linter with docker compose exec rack rubocop -a
• Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

We keep getting blocking step errors when using the Bonds variant, and it's always happening after the game enters phase 8, which is when the bonds are enabled.

It's difficult to test this fix, as the error doesn't happen in my local test environment, but I think the fix here may help. I changed the round_state definition, and modified the related code.

Screenshots

Any Assumptions / Hacks

[ollybh]

You're only using boolean values/tests elsewhere, so you might as well make this boolean values here.

Suggested change

	issued_bond: nil,
	redeemed_bond: nil,
	issued_bond: false,
	redeemed_bond: false,

[ollybh]

@philcampeau Can you explain what you're changing here? There doesn't look to be anything wrong with this change (apart from my minor quibble about using boolean values), but how will this fix the bug?

[philcampeau]

@philcampeau Can you explain what you're changing here? There doesn't look to be anything wrong with this change (apart from my minor quibble about using boolean values), but how will this fix the bug?

To be honest, I don't know if it will fix the issue or not, but I can't figure out what the issue is, and I noticed I did this differently than every other instance on the site, so I figured I might as well try this to see if it helps.

[ollybh]

I can't see how this is going to fix the reported issue, but I can't see any problems with this patch.