Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18RoyalGorge] export all 2+ trains at end of first OR set #11388

Merged
merged 1 commit into from
Dec 15, 2024
Merged

[18RoyalGorge] export all 2+ trains at end of first OR set #11388

merged 1 commit into from
Dec 15, 2024

Conversation

michaeljb
Copy link
Collaborator

Fixes #11359

Pins needed: any games where more than one 2+ train remained at the end of the first OR set

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

@michaeljb michaeljb added the pins PR that will require some games to be pinned label Dec 1, 2024
@ollybh ollybh merged commit 9d6d884 into tobymao:master Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollybh ollybh ollybh approved these changes

@vandamm vandamm vandamm approved these changes

Assignees
No one assigned
Labels
18RoyalGorge pins PR that will require some games to be pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[18RoyalGorge] remaining 2+ Trains were not all exported after first OR set
3 participants
@michaeljb @vandamm @ollybh