[1822/CA and core] fix 1822 tax haven bug #11392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1822's `company_status_str` (called by views) was mutating the value of the private company entity, and there was a substraction operation in place to try to copmensate for that, but that caused tobymao#11040 by subtracting the tax haven's value for other players. This has been simplified with the following approach: - when displaying the company value, call a new wrapper method in the `Game::Base` class - in 1822, override that new method only for the Tax Haven Now the Tax Haven private company entity will always have a value of $0/£0, but the value of the Tax Haven "player" entity is handed off to display methods. Fixes tobymao#11040
michaeljb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1822's
company_status_str(called by views) was mutating the value of the private company entity, and there was a substraction operation in place to try to copmensate for that, but that caused #11040 by subtracting the tax haven's value for other players.This has been simplified with the following approach:
Game::BaseclassNow the Tax Haven private company entity will always have a value of $0/£0, but the value of the Tax Haven "player" entity is handed off to display methods.
Fixes #11040
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rake