Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1822 family] fix Mail Contract interactions with permanent L-trains #11394

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

michaeljb
Copy link
Collaborator

Changed behavior:

  • 1822: Mail Contract no longer pays with LP-train running to a city and town
  • 1822CA: Large Mail Contract no longer pays with LP-train running to a city and town
  • 1822CA: Small Mail Contract now pays with LP-train running to just a city
  • 1822MX: Mail Contract no longer pays with LP-train running to a city and town

Errata references:


Pins not needed since route values are not recomputed when processing the game actions.

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Changed behavior:

* 1822: Mail Contract no longer pays with LP-train running to a city and town
* 1822CA: Large Mail Contract no longer pays with LP-train running to a city and town
* 1822CA: Small Mail Contract now pays with LP-train running to just a city
    * Fixes tobymao#11147
* 1822MX: Mail Contract no longer pays with LP-train running to a city and town

Errata references:

* https://boardgamegeek.com/thread/2640241/article/40423428#40423428
* https://boardgamegeek.com/thread/2640241/article/43680986#43680986
* https://docs.google.com/document/d/1puHQJV4eLeunOtu_RyqAT-_mBCI93u8dqSBNwWMsAiE/
@ollybh ollybh added the 1822 Family 1822 games in general, not just the original 1822 label Dec 15, 2024
@ollybh ollybh merged commit 8fe9584 into tobymao:master Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1822CA 1822 Family 1822 games in general, not just the original 1822 1822MX 1822
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1822CA Small/Large mail contracts not paying with LP run.
2 participants