chore: introduce benchmarking for rust #4552
Open
+808
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benfdking
commented
Dec 30, 2024
benfdking
commented
- introduces a criterion based bench based on the long sql
- introduces serde serializing and deserializing that is not built into the main release
- introduces some json files which are just simple serialization of a set of configs taken from sqlglot
- introduces gha action that compares performance in a pr to main to check for regressions
benfdking
force-pushed
the
introducing_benchmarking
branch
from
1874140 to
c3388f2
Compare
izeigerman
reviewed
Dec 30, 2024
| tokenizer_settings | ||
| } | ||
| } | ||
| #[cfg(feature = "profiling")] |
izeigerman
reviewed
Dec 30, 2024
| pub fn write_json_to_string(&self) { | ||
| let json = serde_json::to_string(self).unwrap(); | ||
| let path = std::path::Path::new(env!("CARGO_MANIFEST_DIR")) | ||
| .join(".hacking/tokenizer_settings.json"); |
There was a problem hiding this comment.
Is this path expected?
There was a problem hiding this comment.
Will fix this is a hangover from me trying to clean things up 🙏 for spotting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.