fix(optimizer)!: simplify connector complements only for non-null operands #6214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geooo109
force-pushed
the
geooo109/opt_complements
branch
2 times, most recently
from
cb7b8a6 to
2b5f95a
Compare
geooo109
force-pushed
the
geooo109/opt_complements
branch
from
2b5f95a to
34eab11
Compare
georgesittas
reviewed
Nov 6, 2025
georgesittas
approved these changes
Nov 6, 2025
georgesittas
approved these changes
Nov 6, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Let's include this in the branch that annotates columns:
if col.type and col.type.args.get("nullable") is False:
col.meta["nonnull"] = True
To account for clickhouse's non-nullable types.
georgesittas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6213