Skip to content

Commit

Permalink
fix: psalm 5
Browse files Browse the repository at this point in the history
  • Loading branch information
darkdarin committed Jul 11, 2024
1 parent 04fcae9 commit 41674d8
Show file tree
Hide file tree
Showing 88 changed files with 506 additions and 216 deletions.
7 changes: 4 additions & 3 deletions psalm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
<psalm xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="https://getpsalm.org/schema/config"
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
errorLevel="6"
findUnusedBaselineEntry="false"
findUnusedCode="false"
errorLevel="5"
findUnusedBaselineEntry="true"
findUnusedCode="true"
findUnusedPsalmSuppress="true"
>
<projectFiles>
<directory name="src" />
Expand Down
9 changes: 6 additions & 3 deletions src/Commands/PromiseClean.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Tochka\Promises\Commands;

use Illuminate\Console\Command;
use Tochka\Promises\Facades\GarbageCollector;
use Tochka\Promises\Core\GarbageCollectorInterface;

class PromiseClean extends Command
{
Expand All @@ -12,10 +12,13 @@ class PromiseClean extends Command
protected $signature = 'promise:clean';
protected $description = 'Собрать мусор и удалить';

public function handle(): void
/**
* @psalm-suppress PossiblyUnusedMethod
*/
public function handle(GarbageCollectorInterface $garbageCollector): void
{
$this->subscribeSignals();

GarbageCollector::clean($this->shouldQuit(...), $this->paused(...));
$garbageCollector->clean($this->shouldQuit(...), $this->paused(...));
}
}
9 changes: 6 additions & 3 deletions src/Commands/PromiseGc.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Tochka\Promises\Commands;

use Illuminate\Console\Command;
use Tochka\Promises\Facades\GarbageCollector;
use Tochka\Promises\Core\GarbageCollectorInterface;

/**
* @codeCoverageIgnore
Expand All @@ -17,10 +17,13 @@ class PromiseGc extends Command
protected $signature = 'promise:gc';
protected $description = 'Сборщик мусора';

public function handle(): void
/**
* @psalm-suppress PossiblyUnusedMethod
*/
public function handle(GarbageCollectorInterface $garbageCollector): void
{
$this->subscribeSignals();

GarbageCollector::handle($this->shouldQuit(...), $this->paused(...));
$garbageCollector->handle($this->shouldQuit(...), $this->paused(...));
}
}
9 changes: 5 additions & 4 deletions src/Commands/PromiseMakeMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ class PromiseMakeMigration extends Command
/** @var array<MigrationContract> */
private array $migrations;

/**
* @psalm-suppress PossiblyUnusedMethod
*/
public function __construct(Filesystem $files, Composer $composer)
{
parent::__construct();
Expand All @@ -44,9 +47,7 @@ public function __construct(Filesystem $files, Composer $composer)
}

/**
* Execute the console command.
*
* @throws \Exception
* @psalm-suppress PossiblyUnusedMethod
*/
public function handle(): void
{
Expand Down Expand Up @@ -94,7 +95,7 @@ public function handle(): void
protected function createTableMigration(string $migrationName): string
{
/** @var MigrationCreator $migrationCreator */
$migrationCreator = $this->laravel['migration.creator'];
$migrationCreator = $this->laravel->make('migration.creator');

return $migrationCreator->create(
$migrationName,
Expand Down
9 changes: 6 additions & 3 deletions src/Commands/PromiseWatch.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Tochka\Promises\Commands;

use Illuminate\Console\Command;
use Tochka\Promises\Facades\PromiseWatcher;
use Tochka\Promises\Core\PromiseWatcherInterface;

/**
* @codeCoverageIgnore
Expand All @@ -18,10 +18,13 @@ class PromiseWatch extends Command

protected $description = 'Смотритель промисов';

public function handle(): void
/**
* @psalm-suppress PossiblyUnusedMethod
*/
public function handle(PromiseWatcherInterface $promiseWatcher): void
{
$this->subscribeSignals();

PromiseWatcher::watch($this->shouldQuit(...), $this->paused(...));
$promiseWatcher->watch($this->shouldQuit(...), $this->paused(...));
}
}
3 changes: 3 additions & 0 deletions src/Conditions/AllJobsInStates.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
use Tochka\Promises\Enums\StateEnum;
use Tochka\Promises\Models\PromiseJob;

/**
* @api
*/
final class AllJobsInStates implements ConditionContract
{
/** @var array<StateEnum> */
Expand Down
3 changes: 3 additions & 0 deletions src/Conditions/AndConditions.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
use Tochka\Promises\Contracts\ConditionContract;
use Tochka\Promises\Core\BasePromise;

/**
* @api
*/
final class AndConditions implements ConditionContract
{
/** @var array<ConditionContract> */
Expand Down
3 changes: 3 additions & 0 deletions src/Conditions/EmptyJobs.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
use Tochka\Promises\Core\BasePromise;
use Tochka\Promises\Models\PromiseJob;

/**
* @api
*/
final class EmptyJobs implements ConditionContract
{
public function condition(BasePromise $basePromise): bool
Expand Down
3 changes: 3 additions & 0 deletions src/Conditions/JobInState.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
use Tochka\Promises\Enums\StateEnum;
use Tochka\Promises\Models\PromiseJob;

/**
* @api
*/
final class JobInState implements ConditionContract
{
private ?int $job_id;
Expand Down
3 changes: 3 additions & 0 deletions src/Conditions/OneJobInState.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
use Tochka\Promises\Core\BasePromise;
use Tochka\Promises\Enums\StateEnum;

/**
* @api
*/
final class OneJobInState implements ConditionContract
{
/** @var array<StateEnum> */
Expand Down
3 changes: 3 additions & 0 deletions src/Conditions/OrConditions.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
use Tochka\Promises\Contracts\ConditionContract;
use Tochka\Promises\Core\BasePromise;

/**
* @api
*/
final class OrConditions implements ConditionContract
{
/** @var array<ConditionContract> */
Expand Down
3 changes: 3 additions & 0 deletions src/Conditions/Positive.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
use Tochka\Promises\Contracts\ConditionContract;
use Tochka\Promises\Core\BasePromise;

/**
* @api
*/
final class Positive implements ConditionContract
{
public function condition(BasePromise $basePromise): bool
Expand Down
3 changes: 3 additions & 0 deletions src/Conditions/PromiseInState.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
use Tochka\Promises\Core\BasePromise;
use Tochka\Promises\Enums\StateEnum;

/**
* @api
*/
final class PromiseInState implements ConditionContract
{
/** @var array<StateEnum> */
Expand Down
3 changes: 3 additions & 0 deletions src/Conditions/Timeout.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
use Tochka\Promises\Contracts\ConditionContract;
use Tochka\Promises\Core\BasePromise;

/**
* @api
*/
final class Timeout implements ConditionContract
{
private Carbon $expired_at;
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/ConditionContract.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Tochka\Promises\Core\BasePromise;

/**
* @codeCoverageIgnore
* @api
*/
interface ConditionContract
{
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/ConditionTransitionsContract.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Tochka\Promises\Core\Support\ConditionTransition;

/**
* @codeCoverageIgnore
* @api
*/
interface ConditionTransitionsContract
{
Expand Down
3 changes: 3 additions & 0 deletions src/Contracts/CustomConnection.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

namespace Tochka\Promises\Contracts;

/**
* @api
*/
interface CustomConnection
{
public function getConnection(): ?string;
Expand Down
3 changes: 3 additions & 0 deletions src/Contracts/CustomQueue.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

namespace Tochka\Promises\Contracts;

/**
* @api
*/
interface CustomQueue
{
public function getQueue(): ?string;
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/DispatcherContract.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Tochka\Promises\Contracts;

/**
* @codeCoverageIgnore
* @api
*/
interface DispatcherContract
{
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/JobFacadeContract.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/**
* Указывает, что BaseJob на самом деле скрывает под собой другой обработчик
*
* @codeCoverageIgnore
* @api
*/
interface JobFacadeContract
{
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/JobStateContract.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Tochka\Promises\Enums\StateEnum;

/**
* @codeCoverageIgnore
* @api
*/
interface JobStateContract
{
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/MayPromised.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Tochka\Promises\Contracts;

/**
* @codeCoverageIgnore
* @api
*/
interface MayPromised
{
Expand Down
3 changes: 3 additions & 0 deletions src/Contracts/NestedEventContract.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

namespace Tochka\Promises\Contracts;

/**
* @api
*/
interface NestedEventContract
{
public function isNested(): bool;
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/PromiseHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Tochka\Promises\Contracts;

/**
* @codeCoverageIgnore
* @api
*/
interface PromiseHandler extends MayPromised
{
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/PromisedEvent.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace Tochka\Promises\Contracts;

/**
* @codeCoverageIgnore
* @api
*/
interface PromisedEvent
{
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/StateChangedContract.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Tochka\Promises\Enums\StateEnum;

/**
* @codeCoverageIgnore
* @api
*/
interface StateChangedContract
{
Expand Down
2 changes: 1 addition & 1 deletion src/Contracts/StatesContract.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Tochka\Promises\Enums\StateEnum;

/**
* @codeCoverageIgnore
* @api
*/
interface StatesContract
{
Expand Down
5 changes: 4 additions & 1 deletion src/Core/BaseJob.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
use Tochka\Promises\Enums\StateEnum;
use Tochka\Promises\Models\PromiseJob;

/**
* @api
*/
class BaseJob implements StatesContract, ConditionTransitionsContract
{
use ConditionTransitions;
Expand All @@ -20,7 +23,7 @@ class BaseJob implements StatesContract, ConditionTransitionsContract
use Time;

private ?int $id = null;
private ?int $promise_id;
private int $promise_id;
private MayPromised $initial_job;
private MayPromised $result_job;
private ?\Throwable $exception = null;
Expand Down
3 changes: 3 additions & 0 deletions src/Core/BasePromise.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
use Tochka\Promises\Enums\StateEnum;
use Tochka\Promises\Models\Promise;

/**
* @api
*/
class BasePromise implements StatesContract, ConditionTransitionsContract
{
use ConditionTransitions;
Expand Down
3 changes: 2 additions & 1 deletion src/Core/FakePromiseRunner.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@
use Tochka\Promises\Contracts\PromiseHandler;

/**
* @api
* @codeCoverageIgnore
*/
class FakePromiseRunner
class FakePromiseRunner implements PromiseRunnerInterface
{
/** @var array<string, PromiseHandler> */
private array $promises = [];
Expand Down
Loading

0 comments on commit 41674d8

Please sign in to comment.