examples: sensors: Support moisture readings #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
force-pushed
the
alistair/moisture
branch
2 times, most recently
from
cac22d8 to
e73423c
Compare
ppannuto
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Looks good to me, only blocking comment is the 'example output'.
Any reason to have a new app here instead of adding to the existing sensors app ( https://github.com/tock/libtock-c/tree/master/examples/sensors ) ?
alistair23
changed the title
Nope! I just didn't know that existed. I've switched to using that instead |
alistair23
force-pushed
the
alistair/moisture
branch
2 times, most recently
from
204d3c5 to
0cb891f
Compare
ppannuto
previously approved these changes
Nov 14, 2024
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
alistair/moisture
branch
from
0cb891f to
0b1a550
Compare
ppannuto
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the new moisture sensor and add a environment sensor example application