[WIP] Topher/add subscription options #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Payment] Accounts that are Past due. CC, cannot be updated. #433 [Payment] Accounts that are Past due. CC, cannot be updated. #433 [Payment] Accounts that are Past due. CC, cannot be updated. #433
…Past-due-CC-cannot-be-updated [Payment] Accounts that are Past due. CC, cannot be updated. #433
tell stripe that we want to skip prorating when a plan changes. Setting skip_prorate_plan_changes=true on the subscription will skip prorating
Update the call to stripe so that we can optionally
two descrete steps. This allows us to record teh stripe id before creating the strip subscription. This prevents race conditions within our system where by stripe was triggering invoice webhook callbacks to our endpoints before we had time to save the stripe_id. Apparently stripe is really fast!
…ions2 Broke the creation of a stripe customer and a stripe subscription into
handle them locally and add them to the ActiveRecord errors collection.
Updated error handling to not bubble up Stripe errors but to
…tr_changed Fix deprecation warning for rails 5.1
topherfangio
commented
Jun 9, 2019
| end | ||
|
|
||
| # CF Template methods. | ||
| def subscription_options(opts = {}) |
There was a problem hiding this comment.
This is the relevant new method. I'm not sure what the other stuff is or why it's showing up in this PR. I guess those changes haven't been merged to master? Or maybe they were reverted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
subscription_optionsmethod for use by mothership subscriptions to add default tax rates