Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new ybinary parser #389

Merged
merged 18 commits into from
Apr 18, 2023
Merged

feat: new ybinary parser #389

merged 18 commits into from
Apr 18, 2023

Conversation

darkskygit
Copy link
Member

fix partial #383

@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 4:01pm

@darkskygit darkskygit temporarily deployed to development April 17, 2023 07:13 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 17, 2023 07:13 — with GitHub Actions Inactive
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@darkskygit darkskygit temporarily deployed to development April 17, 2023 07:26 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 17, 2023 07:26 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 17, 2023 07:26 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 17, 2023 07:43 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 17, 2023 07:43 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 17, 2023 07:43 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 77.42% and project coverage change: +0.52 🎉

Comparison is base (eddc628) 65.20% compared to head (431e30f) 65.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   65.20%   65.73%   +0.52%     
==========================================
  Files         115      125      +10     
  Lines       11445    11938     +493     
==========================================
+ Hits         7463     7847     +384     
- Misses       3982     4091     +109     
Impacted Files Coverage Δ
libs/jwst-codec/src/lib.rs 39.70% <39.70%> (ø)
libs/jwst-codec/src/doc/content.rs 40.81% <40.81%> (ø)
libs/jwst-codec/src/doc/any.rs 50.00% <50.00%> (ø)
libs/jwst-codec/src/doc/id.rs 83.33% <83.33%> (ø)
libs/jwst-codec/src/doc/update.rs 85.71% <85.71%> (ø)
libs/jwst-codec/src/codec/integer.rs 95.27% <95.27%> (ø)
libs/jwst-codec/src/doc/item.rs 96.07% <96.07%> (ø)
libs/jwst-codec/src/codec/buffer.rs 100.00% <100.00%> (ø)
libs/jwst-codec/src/codec/string.rs 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@darkskygit darkskygit temporarily deployed to development April 17, 2023 10:23 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 17, 2023 10:23 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 17, 2023 10:23 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 09:46 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 09:46 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 09:57 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 09:57 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 09:57 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 10:24 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 10:24 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 10:24 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 15:42 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 15:43 — with GitHub Actions Inactive
libs/jwst-codec/src/codec/integer.rs Fixed Show fixed Hide fixed
libs/jwst-codec/src/codec/integer.rs Fixed Show fixed Hide fixed
libs/jwst-codec/src/codec/integer.rs Fixed Show fixed Hide fixed
libs/jwst-codec/src/codec/integer.rs Fixed Show fixed Hide fixed
@darkskygit darkskygit temporarily deployed to development April 18, 2023 16:00 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 16:00 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development April 18, 2023 16:00 — with GitHub Actions Inactive
@darkskygit darkskygit merged commit 421b8b0 into master Apr 18, 2023
@darkskygit darkskygit deleted the feat/jwst-codec branch April 18, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants