Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(blocks): move virutal keyboard controller to affine components #8663

Merged
merged 1 commit into from
Nov 8, 2024
Merged

refactor(blocks): move virutal keyboard controller to affine components #8663

merged 1 commit into from
Nov 8, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Nov 4, 2024 •
edited
Loading

What Changes:

  • Move VirtualKeyboardController to affine-components for common usage

@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 2:59am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 2:59am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e633a2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 4, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@L-Sun Graphite App
Copy link
Contributor Author

L-Sun commented Nov 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

@L-Sun L-Sun mentioned this pull request Nov 4, 2024
Merged
@L-Sun L-Sun changed the title refactor(blocks): move virutal keyboard controller to affine components refactor(blocks): linked doc popover to portal Nov 4, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e633a2d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@L-Sun L-Sun changed the title refactor(blocks): linked doc popover to portal refactor(blocks): render linked doc popover with blocksuit-portal Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.07 MB (-0.04% 🔽)
@blocksuite/affine/block-std 156.69 KB (0%)
@blocksuite/affine/block-std/gfx 80.36 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.8 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.67 KB (0%)
@blocksuite/affine/inline 32.04 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.86 MB (0%)
@blocksuite/affine/blocks 1.96 MB (0%)
@blocksuite/affine/blocks/schemas 88.86 KB (0%)

@L-Sun L-Sun changed the title refactor(blocks): render linked doc popover with blocksuit-portal refactor(blocks): move Nov 4, 2024
@L-Sun L-Sun changed the title refactor(blocks): move refactor(blocks): move Nov 4, 2024
@L-Sun L-Sun changed the title refactor(blocks): move refactor(blocks): move virutal keyboard controller to affine components Nov 4, 2024
@L-Sun L-Sun changed the title refactor(blocks): move virutal keyboard controller to affine components refactor(blocks): move virutal keyboard controller to affine components Nov 4, 2024
@L-Sun L-Sun force-pushed the l-sun/refactor/move-virtual-keyboard-controller branch from d97f0b3 to cabd88e Compare November 6, 2024 01:43
@L-Sun L-Sun mentioned this pull request Nov 6, 2024
Merged
@L-Sun L-Sun force-pushed the l-sun/refactor/move-virtual-keyboard-controller branch from cabd88e to c508e50 Compare November 6, 2024 01:44
@L-Sun L-Sun marked this pull request as ready for review November 6, 2024 03:08
@L-Sun L-Sun requested a review from a team as a code owner November 6, 2024 03:08
@L-Sun L-Sun force-pushed the l-sun/refactor/move-virtual-keyboard-controller branch from c508e50 to 23cc62d Compare November 7, 2024 18:53
@L-Sun L-Sun mentioned this pull request Nov 7, 2024
Merged
@L-Sun L-Sun mentioned this pull request Nov 7, 2024
Merged
@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 8, 2024 •
edited
Loading

Merge activity

@L-Sun
refactor(blocks): move virutal keyboard controller to affine componen…
e633a2d 
…ts (#8663)

### What Changes:
- Move `VirtualKeyboardController` to `affine-components` for common usage
@L-Sun L-Sun force-pushed the l-sun/refactor/move-virtual-keyboard-controller branch from 23cc62d to e633a2d Compare November 8, 2024 02:58
@graphite-app graphite-app bot merged commit e633a2d into master Nov 8, 2024
36 checks passed
@graphite-app graphite-app bot deleted the l-sun/refactor/move-virtual-keyboard-controller branch November 8, 2024 03:03
@L-Sun L-Sun mentioned this pull request Nov 8, 2024
Merged
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flrande Flrande Flrande approved these changes

Assignees

@L-Sun L-Sun

Labels
None yet
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-Sun @Flrande