Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: whiteboard is first loaded, size of the linked doc card is scaled to wrong size #8674

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

akumatus
Copy link
Member

@akumatus akumatus commented Nov 5, 2024

Fix issue BS-1572.

Set the value of _cardStyle at an earlier opportunity, in case the scale calculation uses the old _cardStyle value.

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 8:03am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 8:03am

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: be8ceb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Nov 5, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

akumatus commented Nov 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @akumatus and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 91f70f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.08 MB (-0.01% 🔽)
@blocksuite/affine/block-std 156.43 KB (0%)
@blocksuite/affine/block-std/gfx 80.6 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.8 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.67 KB (0%)
@blocksuite/affine/inline 32.04 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.88 MB (-0.02% 🔽)
@blocksuite/affine/blocks 1.97 MB (+0.09% 🔺)
@blocksuite/affine/blocks/schemas 88.86 KB (0%)

@akumatus akumatus marked this pull request as ready for review November 5, 2024 07:53
@akumatus akumatus requested a review from a team as a code owner November 5, 2024 07:53
Copy link

graphite-app bot commented Nov 5, 2024

Merge activity

…d to wrong size (#8674)

Fix issue [BS-1572](https://linear.app/affine-design/issue/BS-1572).

Set the value of `_cardStyle` at an earlier opportunity, in case the scale calculation uses the old `_cardStyle` value.
@graphite-app graphite-app bot merged commit 91f70f9 into master Nov 5, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fix/linked-card-init-size branch November 5, 2024 08:06
akumatus added a commit that referenced this pull request Nov 6, 2024
- fix: color of canvas element under embed dark theme whiteboard is wrong (#8677)
- fix(edgeless): tool controller potential problem (#8675)
- fix: typeError: f.\_def.innerType.shape[e] is undefined (#8676)
- fix: whiteboard is first loaded, size of the linked doc card is scaled to wrong size (#8674)
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants