Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configrable visibility of reference node popup #8711

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Nov 8, 2024

This PR make the visibility of reference node popup can be configure. Related to BS-1730

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 4:01am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 4:01am

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 217e2cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Nov 8, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Nov 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 217e2cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.07 MB (-0.02% 🔽)
@blocksuite/affine/block-std 156.62 KB (0%)
@blocksuite/affine/block-std/gfx 80.41 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.8 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.6 KB (0%)
@blocksuite/affine/inline 32.04 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.87 MB (+0.03% 🔺)
@blocksuite/affine/blocks 1.96 MB (-0.02% 🔽)
@blocksuite/affine/blocks/schemas 88.86 KB (0%)

@L-Sun L-Sun changed the title chore(inline): configrable reference node popup chore(inline): configrable visibility of reference node popup Nov 8, 2024
@Flrande Flrande changed the title chore(inline): configrable visibility of reference node popup chore: configrable visibility of reference node popup Nov 12, 2024
Copy link
Member

@donteatfriedrice donteatfriedrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-Sun L-Sun added the merge label Nov 12, 2024
Copy link
Contributor Author

L-Sun commented Nov 12, 2024

Merge activity

  • Nov 11, 10:59 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 11, 10:59 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 11, 11:05 PM EST: A user merged this pull request with the Graphite merge queue.

@L-Sun L-Sun force-pushed the l-sun/chore/configrable-reference-node-popup branch from 166ef71 to 217e2cd Compare November 12, 2024 04:00
@graphite-app graphite-app bot merged commit 217e2cd into master Nov 12, 2024
36 checks passed
@graphite-app graphite-app bot deleted the l-sun/chore/configrable-reference-node-popup branch November 12, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants