Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pdf style to attachment #8752

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat: add pdf style to attachment #8752

merged 1 commit into from
Nov 15, 2024
+48 −25

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Nov 15, 2024 •
edited
Loading

What's Changed!

  • adds pdf style to attachment
  • not allowed to switch card style when it is pdf

Screenshot 2024-11-15 at 08.10.08.png

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 1:32am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 1:32am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 03fd5bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app Graphite App
Copy link

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fundon Graphite App
Copy link
Contributor Author

fundon commented Nov 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 15, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 03fd5bb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@fundon fundon marked this pull request as ready for review November 15, 2024 00:03
@fundon fundon requested a review from a team as a code owner November 15, 2024 00:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.07 MB (+0.01% 🔺)
@blocksuite/affine/block-std 156.53 KB (0%)
@blocksuite/affine/block-std/gfx 80.49 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.8 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.6 KB (0%)
@blocksuite/affine/inline 32.09 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.88 MB (+0.01% 🔺)
@blocksuite/affine/blocks 1.96 MB (+0.01% 🔺)
@blocksuite/affine/blocks/schemas 89.22 KB (+0.11% 🔺)

@fundon fundon mentioned this pull request Nov 15, 2024
Open
@doodlewind Graphite App
Copy link
Member

doodlewind commented Nov 15, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 14, 8:28 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 14, 8:29 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 14, 8:29 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 14, 8:36 PM EST: A user merged this pull request with the Graphite merge queue.

@fundon
feat: add pdf style to attachment (#8752)
03fd5bb 
### What's Changed!

* adds `pdf` style to attachment
* not allowed to switch card style when it is pdf

![Screenshot 2024-11-15 at 08.10.08.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/8ypiIKZXudF5a0tIgIzf/a9f25d8a-87bf-42de-bc67-402b947d97ac.png)
@doodlewind doodlewind force-pushed the fundon/11_15_add_pdf_style_to_attachment branch from 0124d65 to 03fd5bb Compare November 15, 2024 01:31
@graphite-app graphite-app bot merged commit 03fd5bb into master Nov 15, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fundon/11_15_add_pdf_style_to_attachment branch November 15, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@fundon fundon

Labels
merge
Projects
BlockSuite Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fundon @doodlewind