Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): only clear surface selection when switching tool #8753

Conversation

doouding
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 216b881

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 8:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 8:09am

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 216b881. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Nov 15, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.07 MB (-0.06% 🔽)
@blocksuite/affine/block-std 156.54 KB (0%)
@blocksuite/affine/block-std/gfx 80.31 KB (-0.22% 🔽)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.85 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.78 KB (0%)
@blocksuite/affine/inline 32.09 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.88 MB (-0.01% 🔽)
@blocksuite/affine/blocks 1.96 MB (-0.04% 🔽)
@blocksuite/affine/blocks/schemas 89.22 KB (0%)

Copy link

graphite-app bot commented Nov 15, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@doouding doouding marked this pull request as ready for review November 18, 2024 07:11
@doouding doouding requested a review from a team as a code owner November 18, 2024 07:11
Copy link
Member

doodlewind commented Nov 18, 2024

Merge activity

  • Nov 18, 3:07 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 18, 3:07 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 18, 3:13 AM EST: A user merged this pull request with the Graphite merge queue.

@doodlewind doodlewind force-pushed the 11-15-fix_edgeless_only_clear_surface_selection_when_switching_tool branch from 9b0315b to 216b881 Compare November 18, 2024 08:08
@graphite-app graphite-app bot merged commit 216b881 into master Nov 18, 2024
36 checks passed
@graphite-app graphite-app bot deleted the 11-15-fix_edgeless_only_clear_surface_selection_when_switching_tool branch November 18, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants