Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed some errors in Makefile for lm preparation #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed some errors in Makefile for lm preparation #36

wants to merge 1 commit into from

Conversation

feifeibear
Copy link

@feifeibear feifeibear commented May 8, 2023 •
edited
Loading

  1. install sentencepiece from github repo. I can not run the .zip version on my MacOS.
  2. make some necessary directories during make
  3. cache the wiki json.gz if has already been downloaded

@feifeibear
Copy link
Author

@mauriceweber could you review this PR?

@feifeibear feifeibear changed the title fixed some errors in Make for lm make fixed some errors in Makefile for lm preparation May 8, 2023
@feifeibear feifeibear mentioned this pull request May 8, 2023
Open
@mauriceweber
Copy link
Collaborator

Hi @feifeibear , thanks a lot for your PR! I will look into it:)

@mauriceweber mauriceweber self-requested a review May 9, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauriceweber mauriceweber Awaiting requested review from mauriceweber

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feifeibear @mauriceweber