This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not really a pull request, more of an explanation on what I had to do to make the ARM macOS build work.
Please note this is just about ARM, not Universal binaries, however I expect building an Universal binary will be basically the same, with the difference of the target platform that gets passed to the compiler.
First, it was necessary to update OpenSSL (which is something that should be done much more often regardless). There is a new version that supports builds for ARM natively.
Second, POCO. POCO has to be rebuilt and the binary sofiles that we`re storing in the repo should be updated to support either ARM or the Universal binaries.
Cocoapods don
t (or didn
t, when I tried it) support ARM builds so I had to rebuild AppAuth and Sparkle from source code and inject them into the Pods folder. I suppose this will get sorted out soon though from the Cocoapods side. I included the binary folders inside the Library folder as AppAuth-actual and Sparkle-actual folders so you can try it yourselves if you want (and can, because ARM macs are not available yet)And finally, the build process has to be adjusted slightly to change the compilation target platform.
All of these steps are also separated into commits in this PR, however this PR shoudln
t be used directly, take it more of a guideline to how to do it in the future. Also there
s probably no hurry because the x86 app still runs fine on the latest Big Sur beta on the DTK.