Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc doc changes #26

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Misc doc changes #26

merged 1 commit into from
Apr 2, 2024

Conversation

kianmeng
Copy link
Contributor

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the source of truth for this Elixir
library and leverage on latest features of ExDoc.

@kianmeng
Copy link
Contributor Author

@adanselm Should I resolve the conflict and resubmit the PR again?

Copy link
Contributor

@kelvinst kelvinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you fix the conflicts and update the branch? We want to merge it and release a new version of the lib soon. Thanks for the PR!

@kianmeng kianmeng force-pushed the misc-doc-changes branch 2 times, most recently from a17656c to 1ada137 Compare April 1, 2024 16:29
Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the source of truth for this Elixir
library and leverage on latest features of ExDoc.
@kianmeng
Copy link
Contributor Author

kianmeng commented Apr 1, 2024

@kelvinst Done.

@kianmeng kianmeng requested a review from kelvinst April 1, 2024 16:31
@lukyanov lukyanov merged commit 6372c57 into toggl:master Apr 2, 2024
1 check failed
@kianmeng
Copy link
Contributor Author

kianmeng commented Apr 3, 2024

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants