Fix "stop tracking on browser close" hook #1767
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remember the Contributing Guidelines ❤️
🌟 What does this PR do?
Tweaks the code to "detect when browser is closed, and stop the running entry". Removed a counting variable and moved everything into the window callback. Tried to await all the promises that happen so we have the best chance of our code being allowed to complete before the browser is gone.
Note: I couldn't reproduce the issue but it looked pretty likely that something could go wrong with it.
Also removed some dead code that was trying to do the same thing
🐛 Recommendations for testing
All changes should be tested across Chrome and Firefox.
Do you know or can you spot a better way to make this behaviour more reliable?
📝 Links to relevant issues or information
Fixes #1687. (Hopefully)