Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab]: Fix selector for sidebar time-tracker class #2156

Merged
merged 2 commits into from
May 18, 2023

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jan 19, 2023

🌟 What does this PR do?

Restore the button that has been gone for a while:

image

I was reported internally by our project manager to your project manager, but no action came out of it, even the issue I had to create myself half year later:

and yet no action to that either, so here's my attempt to do your job what we pay you.

🐛 Recommendations for testing

All changes should be tested across Chrome and Firefox.

📝 Links to relevant issues or information

Fixes #2140

@glensc
Copy link
Contributor Author

glensc commented Jan 19, 2023

CI fails with:

All files src/content/gitlab.js
Error: File src/content/gitlab.js has a faulty header. Check CONTRIBUTING.md
Error: Process completed with exit code 1.

that error message is not useful, what exactly should I check from there? I searched for word "header" and found 0 matches:

$  grep -ci header docs/CONTRIBUTING.md
0

EDIT: proposed fix: #2158

Copy link
Contributor

@Alissonsz Alissonsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It fixes the problem.
Sorry for the big waiting time for the review, and thanks for the help and patience 😄

@Alissonsz Alissonsz merged commit f0fae5f into toggl:master May 18, 2023
@glensc glensc deleted the fix-gitlab-second-button branch May 29, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore Additional toggl button to timetracking block
2 participants