Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/chatbot core #10

Merged
merged 20 commits into from
Sep 13, 2024
Merged

Feat/chatbot core #10

merged 20 commits into from
Sep 13, 2024

Conversation

ranjan-stha
Copy link
Collaborator

Changes

  • Added the chatbot-core components and modules such as Embedding, Database and LLM handlers
  • Updated the environment variables in settings.py

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)

@ranjan-stha ranjan-stha assigned susilnem and udaynwa and unassigned susilnem Sep 10, 2024
thenav56
thenav56 requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few comments/suggestions

chatbot-core/database.py Outdated Show resolved Hide resolved
chatbot-core/database.py Outdated Show resolved Hide resolved
chatbot-core/doc_loaders.py Outdated Show resolved Hide resolved
chatbot-core/embedding.py Outdated Show resolved Hide resolved
chatbot-core/database.py Outdated Show resolved Hide resolved
chatbot-core/utils.py Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
env.sample Outdated Show resolved Hide resolved
main/settings.py Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
thenav56
thenav56 reviewed Sep 11, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@thenav56 thenav56 merged commit 39b3ec1 into develop Sep 13, 2024
5 checks passed
@thenav56 thenav56 deleted the feat/chatbot-core branch September 13, 2024 09:30
sudan45 pushed a commit that referenced this pull request Sep 13, 2024
@ranjan-stha @sudan45
Feat/chatbot core (#10)
7b4a29f 
Add the core chatbot components

* Update the chatbot packages
* Update in db module
* Update Env vars
* Update the python version, pkgs
* Fix some params and Add the embeding wrapper + Update in LLM module
* Update the docker compose file
* Note add regarding embedding model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thenav56 thenav56 thenav56 approved these changes

@sudan45 sudan45 Awaiting requested review from sudan45

Assignees

@udaynwa udaynwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ranjan-stha @thenav56 @susilnem @udaynwa