Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optimization so error object reference does not change #45

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add optimization so error object reference does not change #45

wants to merge 1 commit into from

Conversation

tnagorra
Copy link
Member

Changes

  • Error object was recreated even if value change did not change the error object

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • console.log meant for debugging
  • typos
  • unwanted comments

@tnagorra
Add optimization so error object reference does not change
4b48add 
- Error object was recreated even if value change did not change the
  error object
@tnagorra tnagorra force-pushed the feature/error-obj-optimize-render branch from 53a06e2 to 4b48add Compare July 30, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samshara samshara samshara approved these changes

@frozenhelium frozenhelium Awaiting requested review from frozenhelium

@AdityaKhatri AdityaKhatri Awaiting requested review from AdityaKhatri

Assignees

@frozenhelium frozenhelium

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnagorra @samshara @frozenhelium