Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in WebSocket masking #106

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Fix bug in WebSocket masking #106

merged 2 commits into from
Jul 24, 2023

Conversation

erikcorry
Copy link

No description provided.

@erikcorry erikcorry requested a review from floitsch July 24, 2023 13:13
floitsch
floitsch approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@floitsch
Copy link
Member

Add a test?

floitsch
floitsch approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM.

@erikcorry erikcorry merged commit de6642b into main Jul 24, 2023
3 checks passed
@erikcorry erikcorry deleted the masking-error branch July 24, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floitsch floitsch floitsch approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikcorry @floitsch