-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type propagators truthy test #1980
Open
kasperl
wants to merge
10
commits into
master
Choose a base branch
from
fix-demorgan
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperl
commented
Dec 1, 2023
Comment on lines
1470
to
1498
if (receiver_is_null) { | ||
// If we know the receiver is null, then we can always compute an | ||
// answer. If the argument is any, we don't know if the result is | ||
// true or false. Otherwise, the result is true if the argument | ||
// is null and false if the argument is non-null. | ||
if (argument_is_any) { | ||
stack->push_bool(program); | ||
} else { | ||
stack->push_bool_specific(program, argument_is_null); | ||
} | ||
ret(propagator_, stack); | ||
delete scope; | ||
return; | ||
} | ||
|
||
if (argument_is_null) { | ||
// The receiver isn't null, so if the argument is null we | ||
// know that the result is false. | ||
stack->push_bool_specific(program, false); | ||
ret(propagator_, stack); | ||
delete scope; | ||
return; | ||
} else if (argument_is_any) { | ||
// The receiver isn't null, so unless we know the argument | ||
// cannot be null, we must add both true and false to the | ||
// result but continue analyzing the method. | ||
stack->push_bool(program); | ||
ret(propagator_, stack); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if (receiver_is_null) { | |
// If we know the receiver is null, then we can always compute an | |
// answer. If the argument is any, we don't know if the result is | |
// true or false. Otherwise, the result is true if the argument | |
// is null and false if the argument is non-null. | |
if (argument_is_any) { | |
stack->push_bool(program); | |
} else { | |
stack->push_bool_specific(program, argument_is_null); | |
} | |
ret(propagator_, stack); | |
delete scope; | |
return; | |
} | |
if (argument_is_null) { | |
// The receiver isn't null, so if the argument is null we | |
// know that the result is false. | |
stack->push_bool_specific(program, false); | |
ret(propagator_, stack); | |
delete scope; | |
return; | |
} else if (argument_is_any) { | |
// The receiver isn't null, so unless we know the argument | |
// cannot be null, we must add both true and false to the | |
// result but continue analyzing the method. | |
stack->push_bool(program); | |
ret(propagator_, stack); | |
} | |
if (argument_is_any) { | |
stack->push_bool(program); | |
ret(propagator_, stack); | |
if (receiver_is_null) { | |
delete scope; | |
return; | |
} | |
} else if (receiver_is_null || argument_is_null) { | |
stack->push_bool_specific(program, receiver_is_null && argument_is_null); | |
ret(propagator_, stack); | |
delete scope; | |
return; | |
} |
erikcorry
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there's a test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.