Give BLE scan more options. #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out the fields and make them accessible. This makes it possible to move more code into Toit, and also gives more control to users that need more advanced advertisement fields.
Active scans send a request to the device when they have received an advertisement.
Most users shouldn't touch them, but for power users it's nice to have them available.
We don't want to accidentally run board1 and board2 of unrelated tests.
kasperl
approved these changes
Nov 25, 2024
src/resources/ble_esp32.cc
Outdated
| @@ -2443,10 +2443,10 @@ PRIMITIVE(scan_start) { | |||
| disc_params.passive = passive ? 1 : 0; | |||
|
|
|||
| /* Use defaults for the rest of the parameters. */ | |||
| @@ -62,12 +62,17 @@ main-peripheral: | |||
| next-semaphore.down | |||
| peripheral.stop-advertise | |||
|
|
|||
| is-general-advertisement := false | |||
…h/ble-extended-scan.20.active-scan
…h/ble-extended-scan.30.more-options
…h/ble-extended-scan.20.active-scan
…h/ble-extended-scan.30.more-options
…h/ble-extended-scan.20.active-scan
Base automatically changed from
floitsch/ble-extended-scan.20.active-scan
to
master
November 25, 2024 13:58
…h/ble-extended-scan.30.more-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most users shouldn't touch them, but for power users it's nice to have them available.