Roll esp-idf to 5.1. #2650
Roll esp-idf to 5.1. #2650
Conversation
floitsch
force-pushed
the
floitsch/update-idf
branch
from
9fbf46a
to
179d861
Compare
|
Currently points to 5.1-dev. I will update this PR once 5.1-dev has been merged into 5.1. |
mbedtls/include/README.md
Outdated
| # Toit configuration for mbedtls | ||
|
|
||
| This directory contains the configuration for building mbedtls with Toit. | ||
| When compiling for the ESP32 family, the ESP-IDF configuration is used. |
There was a problem hiding this comment.
So these two files are ignored on esp-idf? Maybe clarify. Also where is the esp-idf configuration stored?
mbedtls/include/README.md
Outdated
|
|
||
| When updating mbedtls to a new version, the configuration files should be | ||
| updated to match the new version. Replace the `default_config.h` with the | ||
| new version and update the `toit_config.h` to match the changes. |
There was a problem hiding this comment.
Where do you get the new default version from? I guess it is a copy of mbedtls_config.h? Why do we need to have an unused copy? I'm not sure I follow the "serves as a reference for the configuration options" part.
Is it because the mbedtls_config.h file lives in another repository?
There was a problem hiding this comment.
It's just to have the "old" config file as reference to make diffs and see what we changed.
I clarified the text and added a Makefile check to ensure we don't forget to update it when we roll a new esp-idf.
done.
No description provided.