Fix/stop process #115
Merged
Fix/stop process #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4000D
reviewed
Apr 14, 2020
There was a problem hiding this comment.
@sifnoc I think sending tm.quit as a parameter is not needed because re-ordering in https://github.com/Onther-Tech/plasma-evm/pull/115/files#diff-d4e7314a5d64e9f6bd6e77e2796e4079L167-R168 would fix it.
I thought that but even if change reordered, still happens(rarely), I will reproduce without checking |
sifnoc
force-pushed
the
fix/stop-process
branch
from
db340d2 to
4838a27
Compare
4000D
reviewed
Apr 20, 2020
sifnoc
force-pushed
the
fix/stop-process
branch
from
fffe138 to
a1dab59
Compare
4000D
suggested changes
Apr 20, 2020
added 2 commits
April 20, 2020 19:40
changed WaitGroup declare
sifnoc
force-pushed
the
fix/stop-process
branch
from
656e43d to
23ce95b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing for Issue #114
Update
circleciConfig and tx test package account.