Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying colour sets (overrides) to re-theme the design doesn't work #1858

Closed
Arno-Sympower opened this issue May 4, 2023 · 5 comments
Closed
Labels
bug Something isn't working ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post Figma non-local styles variables Publishing comp lib, styles and variables to consume plugin v2.1 Token viewing experience theme token set override token type color

Comments

@Arno-Sympower
Copy link

Arno-Sympower commented May 4, 2023

Describe the bug
Applying colour sets (overrides) to re-theme the design doesn't work in an external Figma file with the library linked and studio tokens synced (Github).

To Reproduce
Steps to reproduce the behavior:

  1. When in the component library (MUI in my case) I can add a set of alternate colours, apply It and It works perfectly.
  2. Then I create a new file, put a screen with some components in It, link the library, sync the token studio colours, apply the new colour set: nothing happens.
  3. When I go back to the library an apply the colours with the token studio colour tokens again manually (toggeling the colour on/off), publish the library and accept changes in the other file, It does work. But why does It work within the library itself out of the box and not on external files out of the box since It's already proven to be linked?

It's very tedious to now having to go through every layer with colour properties in all components. Especially because It seems to work out of the box within the library Itself. I'm confused.

Expected behavior
That It works?

@keeganedwin
Copy link
Collaborator

keeganedwin commented Nov 21, 2023

Hey @Arno-Sympower are you still facing this issue?

@SamIam4Hyma SamIam4Hyma added plugin v2 variables, UI, WTCG format, Bitbucket ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post labels Apr 10, 2024
@SamIam4Hyma
Copy link
Collaborator

Added to Featurebase Roadmap as a known issue in progress of being fixed - 🚧 ❖❇️ Export styles and variables using sets (free plan)

@UdayHyma
Copy link
Collaborator

Added to FeatureBase Roadmap- ❖ ❇️ Non-local support of variables and styles

@SamIam4Hyma SamIam4Hyma added plugin v2.1 Token viewing experience and removed plugin v2 variables, UI, WTCG format, Bitbucket labels May 14, 2024
@SamIam4Hyma
Copy link
Collaborator

if a person is wanting to use theming they should use a pure token flow or theme groups. It has dependencies on non-local file support or choosing if tokens should be style, variables etc.

@SamIam4Hyma
Copy link
Collaborator

closing this ticket for now until we have more info from the OP.

@github-project-automation github-project-automation bot moved this from 📥 Triage to ✅ Done in Tokens Studio for Figma Roadmap Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post Figma non-local styles variables Publishing comp lib, styles and variables to consume plugin v2.1 Token viewing experience theme token set override token type color
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants