fix: documentation tokens

[six7]

This pull request includes changes to the mapValuesToTokens function in src/plugin/node.ts to modify the way descriptions and modifiers are added to tokens.

• src/plugin/node.ts: Updated mapValuesToTokens function to modify the way descriptions and modifiers are added to tokens. [1] [2]

[changeset-bot]

🦋 Changeset detected

Latest commit: 87028e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@tokens-studio/figma-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Analysis

• 🎯 Main theme: Fixing the way descriptions and modifiers are added to tokens in the mapValuesToTokens function.
• 📝 PR summary: This PR modifies the mapValuesToTokens function in src/plugin/node.ts to change how descriptions and modifiers are added to tokens. It also includes a changeset file to document the changes made.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 2
  The PR is not very large and the changes are relatively straightforward. However, understanding the context and the impact of the changes might require some time.
• 🔒 Security concerns: No

PR Feedback

• 💡 General suggestions: The changes in the PR seem to be addressing the issue at hand. However, it would be beneficial to add tests to verify the correctness of the changes and prevent future regressions.

• 🤖 Code feedback:

  • relevant file: src/plugin/node.ts
    suggestion: It's recommended to use nullish coalescing operator (??) instead of logical OR (||) when dealing with potential null or undefined values. This is because || operator will return the right-hand side operand if the left-hand side operand is any falsy value, not just null or undefined. [important]
    relevant line: acc[key] = resolvedToken[returnValueToLookFor(key)] || resolvedToken.value;

  • relevant file: src/plugin/node.ts
    suggestion: Consider using optional chaining when accessing deeply nested properties. This can help avoid runtime errors when one of the intermediate properties is undefined. [medium]
    relevant line: if (returnValueToLookFor(key) === 'rawValue' && resolvedToken.$extensions?.['studio.tokens']?.modify) {

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

[github-actions]

Commit SHA:bf2b8a183ef52c805402c2bc6905a5bc952b509d

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix/documentation-tokens-not-applying 

Status	File	% Stmts	% Branch	% Funcs	% Lines
🔴	total	71.13 (-0.01)	61.51 (-0.01)	69.32 (0)	71.38 (-0.01)
🔴	src/plugin/node.ts	85.71 (-0.87)	71.28 (-1.44)	87.5 (0)	86.41 (-0.93)

[github-actions]

Commit SHA:bf2b8a183ef52c805402c2bc6905a5bc952b509d
Current PR reduces the test coverage percentage by 100 for some tests