Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When switching themes switch the figma native theme mode selector if possible #2336

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

When switching themes switch the figma native theme mode selector if possible #2336

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
11ec40d
add console logs to figure out issues
robinhoodie0823 Oct 16, 2023
76fb981
clean console log
robinhoodie0823 Oct 17, 2023
4fdd735
Merge branch 'main' of https://github.com/tokens-studio/figma-plugin …
robinhoodie0823 Oct 23, 2023
a45930e
apply style to figma check
robinhoodie0823 Oct 24, 2023
99d2004
switching active theme in plugin
robinhoodie0823 Oct 25, 2023
e8026a1
resolve comments
robinhoodie0823 Nov 7, 2023
31099b0
feat: add changeset
robinhoodie0823 Nov 7, 2023
64a4de2
Merge branch 'main' of https://github.com/tokens-studio/figma-plugin …
robinhoodie0823 Dec 5, 2023
253eca3
update: update the logic
robinhoodie0823 Jan 10, 2024
c1b0204
Merge branch 'main' of https://github.com/tokens-studio/figma-plugin …
robinhoodie0823 Jan 10, 2024
3fbd4d7
update to pass test case
robinhoodie0823 Jan 10, 2024
21f2ae5
feat: add changest
robinhoodie0823 Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/AsyncMessageChannel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,16 @@ export class AsyncMessageChannel {
this.attachMessageListener((msg: IncomingMessageEvent<AsyncMessageResults & { type: Message['type'] }>['data']['pluginMessage']) => {
if (msg.id === messageId) {
if ('message' in msg) {
if (msg.message.type === 'async/get-theme-info') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this belongs here. this file doesnt have any of the other message handlers, this needs to go elsewhere where we define those.

figma-plugin/src/app/components/Initiator.tsx

Line 31 in 1424c9f

switch (pluginMessage.type) {

this feels like the right place

if ('activeTheme' in msg.message && 'themes' in msg.message) {
const { activeTheme } = msg.message;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const { activeTheme } = msg.message;
const { activeTheme, themes } = msg.message;

const { themes } = msg.message;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const { themes } = msg.message;
const themeToFind = Object.values(activeTheme)[0];

const activeMode = themes.filter((theme) => theme.id === Object.values(activeTheme)[0])[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const activeMode = themes.filter((theme) => theme.id === Object.values(activeTheme)[0])[0];
const activeMode = themes.find((theme) => theme.id === themeToFind);

figma.currentPage.children.forEach((frame) => {
frame.setExplicitVariableModeForCollection(activeMode.$figmaCollectionId ?? '', activeMode.$figmaModeId ?? '');
});
}
}
resolve(msg.message);
} else {
reject(msg.error);
Expand Down
1 change: 1 addition & 0 deletions src/app/store/models/reducers/tokenState/setActiveTheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export function setActiveTheme(state: TokenState, { newActiveTheme }: { newActiv
[tokenSet, TokenSetStatus.DISABLED]
)),
);

return {
...state,
usedTokenSet: usedTokenSetsMap,
Expand Down
Loading