Change font-size input field position in Typography composite token modal #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odal Current: Font size is after line-height Problem: Line-height is often dependent on font-size, so it would help to first set the font-size and then the line-height. Solution: Change the font-size input field position in the Typography composite token modal. PS: this is my first ever contribution to an open-source project, please be gentle when looking at naming conventions for branches/commits
🦋 Changeset detectedLatest commit: 36bf68a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey Victor, congratulations on submitting your first PR! This would be a feat/ rather than a hotfix. But it's fine, we're not reliant on branch names to set up our change logs here. |
LukeFinch
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current: Font size is after line-height
Problem: Line-height is often dependent on font-size, so it would help to first set the font-size and then the line-height.
Solution: Change the font-size input field position in the Typography composite token modal.
PS: this is my first ever contribution to an open-source project, please be gentle when looking at naming conventions for branches/commits