fix applying typography tokens variable values #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f868390 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
Commit SHA:097bc4ddfb2e6ca82b48d4bc00d1a71cb4645055 Test coverage results 🧪
|
|
Commit SHA:097bc4ddfb2e6ca82b48d4bc00d1a71cb4645055 |
six7
reviewed
Dec 23, 2024
packages/tokens-studio-for-figma/src/plugin/applyTypographyTokenOnNode.ts
Outdated
Show resolved
Hide resolved
six7
approved these changes
Dec 23, 2024
akshay-gupta7
deleted the
fix-typography-tokens-variables-application
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Closes #3215
What does this pull request do?
Addresses the concern where a typography token is applied with exported variables and the applied variable is not displayed in Figma.
Testing this change
Additional Notes (if any)