Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paragraph indent typography token #3242

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

akshay-gupta7
Copy link
Contributor

Why does this PR exist?

Fixes #3201

What does this pull request do?

This PR fixes an issue when the user tries to apply paragraph Indent property from a typography token

Testing this change

  • Create a typography token with paragraph indent property
  • Apply to a text node in Figma
  • It should now apply

Additional Notes (if any)

@akshay-gupta7 akshay-gupta7 self-assigned this Jan 8, 2025
Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: d82a821

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 8, 2025

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Commit SHA:c41f38ba108949ee84e66c39d024b65991345824

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-paragraph-indent-typography-token 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 67.08 (0) 58.06 (0.01) 63.87 (0) 67.45 (0)
🔴 packages/tokens-studio-for-figma/src/plugin/applyTypographyTokenOnNode.ts 76.92 (0) 78.08 (-0.18) 100 (0) 75 (0)

@akshay-gupta7 akshay-gupta7 requested a review from six7 January 8, 2025 12:14
Copy link
Collaborator

@six7 six7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset please

@akshay-gupta7 akshay-gupta7 merged commit b08d2fd into main Jan 9, 2025
10 checks passed
@akshay-gupta7 akshay-gupta7 deleted the fix-paragraph-indent-typography-token branch January 9, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paragraph Indent not applying
2 participants