Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ts theme metadata #3243

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Fix ts theme metadata #3243

merged 5 commits into from
Jan 17, 2025

Conversation

roppazvan
Copy link
Collaborator

Why does this PR exist?

  • TS sync removed some metadata from themes like figmaModeId or figmaCollectionId. Fixed this issue by querying for that data and also updating it properly.
  • Also updated the types and sdk packages

Closes #0000

What does this pull request do?

Testing this change

Additional Notes (if any)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 67d052e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Commit SHA:b34779616219cc65bc1573abbcf04fa3162b52e7

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-ts-theme-metadata
Status File % Stmts % Branch % Funcs % Lines
🔴 total 67.03 (0.01) 58.02 (-0.03) 63.89 (0) 67.4 (0)
🔴 packages/tokens-studio-for-figma/src/storage/TokensStudioTokenStorage.ts 50.61 (0.3) 32.85 (-1.99) 52.17 (0) 51.89 (0.61)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Commit SHA:b34779616219cc65bc1573abbcf04fa3162b52e7
Current PR reduces the test coverage percentage by 1 for some tests

six7
six7 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@six7 six7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset please

packages/tokens-studio-for-figma/package.json
@@ -62,7 +62,7 @@
"@supabase/supabase-js": "^2.0.5",
"@supernovaio/supernova-sdk": "^1.9.3",
"@tokens-studio/graph-engine": "^0.17.5",
"@tokens-studio/sdk": "^2.0.0-alpha.0",
"@tokens-studio/sdk": "^1.4.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose? Sdk 1.4.2 is a prior version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, 1.4.2 is the latest

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to 2.0.0.-alpha?

akshay-gupta7
akshay-gupta7 reviewed Jan 16, 2025
View reviewed changes
packages/tokens-studio-for-figma/src/storage/TokensStudioTokenStorage.ts Outdated
@@ -427,7 +429,7 @@ export class TokensStudioTokenStorage extends RemoteTokenStorage<TokensStudioSav
const responseData = await this.client.mutate({
mutation: DELETE_THEME_GROUP_MUTATION,
variables: {
branch: 'master',
branch: 'main',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be DEFAULT_BRANCH as well right?

@roppazvan roppazvan merged commit 03237ae into main Jan 17, 2025
9 of 10 checks passed
@roppazvan roppazvan deleted the fix-ts-theme-metadata branch January 17, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@six7 six7 six7 approved these changes

@akshay-gupta7 akshay-gupta7 akshay-gupta7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roppazvan @six7 @akshay-gupta7