Gracefully handle missing headers #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a failing test for missing Content-Encoding header that should result in an empty-list Content-Encoding instead of an error.
Reports a missing header rejection only if the header's decoder didn't return a default value. Closes tokio-rs#1781.
jplatte
reviewed
Mar 3, 2023
There was a problem hiding this comment.
If @davidpdrsn agrees, I think we can merge this as a non-breaking change.
This avoids relying on Debug representation of the opaque ContentEncoding type.
davidpdrsn
reviewed
Mar 3, 2023
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports a missing header rejection only if the header's decoder didn't return a default value.
I've also added a regression test by using Cookie as an example: missing Cookie should be treated in the same way as empty Cookie header, but before this PR would reject the entire request. Now it's going to be handled correctly.
Closes #1781.