Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention updated dependencies in changelog #2359

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

davidpdrsn
Copy link
Member

Probably good to mention this otherwise its not very obvious.

@davidpdrsn davidpdrsn requested a review from jplatte November 27, 2023 12:17
@davidpdrsn davidpdrsn enabled auto-merge (squash) November 27, 2023 12:18
- [hyper](https://crates.io/crates/hyper) 1.0
- [http](https://crates.io/crates/http) 1.0
- [http-body](https://crates.io/crates/http-body) 1.0
- [tower-http](https://crates.io/crates/tower-http) 0.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tower-http is not a public dep.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. How to phrase it then 🤔 I do still wanna make people aware of having to update tower-http at the same time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like 34d9659

@davidpdrsn davidpdrsn requested a review from jplatte November 27, 2023 12:35
@davidpdrsn davidpdrsn merged commit 6641e93 into main Nov 27, 2023
18 checks passed
@davidpdrsn davidpdrsn deleted the david/mention-new-versions-in-changelog branch November 27, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants