Implement TypedPath for WithRejection<TypedPath, _>
#2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jplatte
reviewed
Jan 4, 2024
Comment on lines
140
to
141
| #[cfg(feature = "typed-routing")] | ||
| const _: () = { |
There was a problem hiding this comment.
Why do it this way? I find the const _ trick a bit weird.
There was a problem hiding this comment.
Just so you don't need to put #[cfg(feature = "typed-routing")] on the imports as well (unless you want warnings) or use fully qualified paths.
There was a problem hiding this comment.
I think I'd prefer either of those solutions 😅
cc rust-lang/rust#65516 ;)
There was a problem hiding this comment.
I hope that doesn't land 😅 I think its pretty useful to be able to define stuff everywhere though I do see its a nightmare from and IDE point of view.
But I've fixed it in c1b2756
jplatte
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2489