Fix cargo hack warnings
#3114
Merged
Fix cargo hack warnings
#3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems unrelated to "request parts", so let's give it a more reasonable name.
This fixes a compiler warning when used with `--no-default-features`
This fixes a compiler warning when used with `--no-default-features`
…cros are not used This fixes a compiler warning when used with `--no-default-features`
Turbo87
commented
Dec 27, 2024
| @@ -0,0 +1,85 @@ | |||
| use super::{Extension, FromRequestParts}; | |||
| use http::{request::Parts, Uri}; | |||
| use std::convert::Infallible; | |||
There was a problem hiding this comment.
in this case cargo hack complained about Infallible being unused without the original-uri feature. this was caused by the request_parts module being compiled in unconditionally and the cfg(feature) attributes being applied to each thing in this module individually.
I've extracted the OriginalUri implementation into a dedicated module and applied the cfg(feature) attribute to the mod original_uri declaration to avoid this issue, which is why the diff for this fix is a bit larger than the others.
jplatte
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
cargo hackCI job was showing several warnings for certain feature combinations. This PR fixes these issues and adjusts the CI workflow to fail the build forcargo hackwarnings in the future to prevent this from regressing.