Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ok on Child::start_kill after wait #7160

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Ok on Child::start_kill after wait #7160

merged 1 commit into from
Feb 15, 2025

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Feb 15, 2025 •
edited
Loading

  • there's no good reason to my knowledge to return error in kill of killed process
  • start_kill is often used in cleanup, which may happen after wait, so better not error there
  • this matches behavior of std Child::kill

@maminrayej maminrayej added A-tokio Area: The main tokio crate M-process Module: tokio/process labels Feb 15, 2025
maminrayej
maminrayej approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@maminrayej maminrayej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@maminrayej maminrayej merged commit 8e13417 into tokio-rs:master Feb 15, 2025
87 checks passed
stepancheg added a commit to stepancheg/tokio that referenced this pull request Feb 16, 2025
@stepancheg
Test for Child::kill after wait
cbd599b 
Forgot to submit as part of tokio-rs#7160
@stepancheg stepancheg mentioned this pull request Feb 16, 2025
Merged
@stepancheg stepancheg deleted the pr7160 branch February 16, 2025 04:41
stepancheg added a commit to stepancheg/tokio that referenced this pull request Feb 17, 2025
@stepancheg
Test for Child::kill after wait
c941553 
Forgot to submit as part of tokio-rs#7160
stepancheg added a commit to stepancheg/tokio that referenced this pull request Feb 17, 2025
@stepancheg
Test for Child::kill after wait
71a9146 
Forgot to submit as part of tokio-rs#7160
stepancheg added a commit to stepancheg/tokio that referenced this pull request Feb 18, 2025
@stepancheg
Test for Child::kill after wait
c522952 
Forgot to submit as part of tokio-rs#7160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maminrayej maminrayej maminrayej approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-process Module: tokio/process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepancheg @maminrayej