Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on master #15

Merged
merged 1 commit into from
May 12, 2021
Merged

Fix build error on master #15

merged 1 commit into from
May 12, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 12, 2021

impl Valuable for Arc<[T]> is added in #13, but when that PR was opened, #12 had not yet been merged, so #13 did not handle targets that do not support atomic CAS.

As a result, the CI of the master branch is currently failing:

error[E0433]: failed to resolve: could not find `sync` in `alloc`
  --> valuable/src/listable.rs:73:26
   |
73 |     (T: Valuable) alloc::sync::Arc<[T]>,
   |                          ^^^^ could not find `sync` in `alloc`

https://github.com/tokio-rs/valuable/runs/2560992823?check_suite_focus=true

@taiki-e taiki-e requested a review from carllerche May 12, 2021 01:45
@carllerche carllerche merged commit 74a2b67 into master May 12, 2021
@taiki-e taiki-e deleted the taiki-e/fix branch May 12, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants