ast/tests: Repeat type resolution for arguments in lambda to fix #3315 and fix #3308 #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type resolution was missing for arguments in a partial call. The type feature is required as well and is created explicitly, marked this with NYI since it is unclear why this does not happen automatically. The issue from #3315 is no longer commented out in tests/reg_issue3308 and an even simpler example was added as well.
…tures... ...except for calls to outer refs.
fridis
changed the title
…caton The actual arguments' types must be resolved again if the outer type they were resolved again has changed due to lambda, lazy or partial application. Added new field `Call._actualsResolvedFor` the detect the need to re-resolve the actual argument types. Move syntax sugar for field initialization form `RESOLVING_TYPES` phase to `SYNTAX_SUGAR1` phase to properly separate this in case the field initial value ends up being a lambda/lazy/partial.
Also duplicated the tests in `reg_issue3308` to be executed within a function `b` additionally to the constructor `a`. This includes the case from #3324, which is currently commented out in the test.
Do not set `Call._actualsResolvedFor` to null if the outer has changed and the actuals will get re-resolved anyway.
fridis
changed the title
michaellilltokiwa
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type resolution has top be repeated for actual arguments in a lambda, lazy or partial call since the outer feature has changed.
For this to work, the code that assigns the initial value to a field must be created later, i.e, not during
resolveTypesbut in phasesyntaxSugar1.The issue from #3315 is no longer commented out in tests/reg_issue3308 and an even simpler example was added as well. This PR also adds new test cases with outer feature being a function and not a constructor. This includes a commented-out version of the example in #3324, which does not work yet.