ast: When checking actual type par against constraints, do not walk through inh chain of choice Fix #3362 #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrough inh chain of choice Fix #3362 Since choice types cannot be called, the result of a call to `choice X Y Z` is `void`, which lead to choice types that inherit from choice to be accepted to match any constraint. This patch fixes this by not walking through the parents if the actual type parameter is a choice. This also adds a regression test with the original code from #3362 and a minimalistic example.
simonvonhackewitz
approved these changes
Jul 15, 2024
Otherwise `option T`, which is a choice, would not be assignable to `Sequence T`-
Otherwise `option T`, which is a choice, would not be assignable to `Sequence T`-
michaellilltokiwa
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since choice types cannot be called, the result of a call to
choice X Y Zisvoid, which lead to choice types that inherit from choice to be accepted to match any constraint. This patch fixes this by not walking through the parents if the actual type parameter is a choice.This also adds a regression test with the original code from #3362 and a minimalistic example.