Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bool: make the ternary operator lazy #3404

Merged
merged 1 commit into from
Jul 18, 2024
Merged

bool: make the ternary operator lazy #3404

merged 1 commit into from
Jul 18, 2024

Conversation

maxteufel
Copy link
Collaborator

No description provided.

@maxteufel maxteufel linked an issue Jul 18, 2024 that may be closed by this pull request
Ternary operator is not lazy #3330
Closed
fridis
fridis requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.
Please also change the signature of ternary ? : in bool.fz such that a and b are Lazy.

@maxteufel
Copy link
Collaborator Author

@fridis: not possible due to #1726 and #2301, i marked this with a NYI comment

@maxteufel maxteufel requested a review from fridis July 18, 2024 08:00
@maxteufel maxteufel merged commit 127b16c into tokiwa-software:main Jul 18, 2024
4 checks passed
@maxteufel maxteufel deleted the bool_ternary_operator_lazy branch July 18, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

@michaellilltokiwa michaellilltokiwa michaellilltokiwa approved these changes

@simonvonhackewitz simonvonhackewitz simonvonhackewitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ternary operator is not lazy
4 participants
@maxteufel @fridis @michaellilltokiwa @simonvonhackewitz