Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add internationalization effect #3571

Merged
merged 21 commits into from
Aug 20, 2024
Merged

lib: add internationalization effect #3571

merged 21 commits into from
Aug 20, 2024

Conversation

lisaw0
Copy link
Contributor

@lisaw0 lisaw0 commented Aug 16, 2024 •
edited
Loading

Add internationalization effect to format date based on location.

fridis
fridis requested changes Aug 16, 2024
View reviewed changes
lib/internationalization/ISO_handler.fz Outdated Show resolved Hide resolved
lib/internationalization/ISO_handler.fz Outdated Show resolved Hide resolved
lib/internationalization/ISO_handler.fz Outdated Show resolved Hide resolved
fridis
fridis requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@fridis fridis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I have added a number of smaller suggestions, mostly affecting formatting or some text formulation.

Please fix and then this should be ready to be merged!

lib/internationalization/german_handler.fz Outdated Show resolved Hide resolved
lib/internationalization/american_handler.fz Outdated Show resolved Hide resolved
lib/internationalization/ISO_handler.fz Outdated Show resolved Hide resolved
lib/internationalization/american_handler.fz Outdated Show resolved Hide resolved
lib/internationalization/german_handler.fz Outdated Show resolved Hide resolved
lib/internationalization/korean_handler.fz Outdated Show resolved Hide resolved
lib/internationalization.fz Outdated Show resolved Hide resolved
lib/internationalization/int_eff.fz Outdated Show resolved Hide resolved
lib/internationalization/int_handler.fz Outdated Show resolved Hide resolved
lib/internationalization/ISO_handler.fz Outdated Show resolved Hide resolved
lisaw0 and others added 9 commits August 19, 2024 13:07
@lisaw0
Merge branch 'main' into internationalization
b57b003
@lisaw0 @fridis
improvement in describtion
fc7d905 
Co-authored-by: Fridtjof Siebert <[email protected]>
@lisaw0 @fridis
improvement of phrasing
87cac0c 
Co-authored-by: Fridtjof Siebert <[email protected]>
@lisaw0 @fridis
refinement of wording
1de5aff 
Co-authored-by: Fridtjof Siebert <[email protected]>
@lisaw0 @fridis
correcting date-format
03b7022 
Co-authored-by: Fridtjof Siebert <[email protected]>
@lisaw0 @fridis
correcting syntax
c9bda1b 
Co-authored-by: Fridtjof Siebert <[email protected]>
@lisaw0 @fridis
add space
acfe65e 
Co-authored-by: Fridtjof Siebert <[email protected]>
@lisaw0 @fridis
add space and spelling mistake
28feda1 
Co-authored-by: Fridtjof Siebert <[email protected]>
@lisaw0 @fridis
add spelling mistake and format
b887f40 
Co-authored-by: Fridtjof Siebert <[email protected]>
michaellilltokiwa
michaellilltokiwa approved these changes Aug 19, 2024
View reviewed changes
lib/internationalization/korean_handler.fz Outdated Show resolved Hide resolved
lib/internationalization/japanese_handler.fz Outdated Show resolved Hide resolved
lib/internationalization.fz Outdated Show resolved Hide resolved
@fridis fridis merged commit d4f304f into tokiwa-software:main Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridis fridis fridis approved these changes

@michaellilltokiwa michaellilltokiwa michaellilltokiwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lisaw0 @fridis @michaellilltokiwa