-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: add internationalization effect #3571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridis
requested changes
Aug 16, 2024
fridis
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I have added a number of smaller suggestions, mostly affecting formatting or some text formulation.
Please fix and then this should be ready to be merged!
Co-authored-by: Fridtjof Siebert <[email protected]>
Co-authored-by: Fridtjof Siebert <[email protected]>
Co-authored-by: Fridtjof Siebert <[email protected]>
Co-authored-by: Fridtjof Siebert <[email protected]>
Co-authored-by: Fridtjof Siebert <[email protected]>
Co-authored-by: Fridtjof Siebert <[email protected]>
Co-authored-by: Fridtjof Siebert <[email protected]>
Co-authored-by: Fridtjof Siebert <[email protected]>
lisaw0
commented
Aug 19, 2024
lisaw0
commented
Aug 19, 2024
michaellilltokiwa
approved these changes
Aug 19, 2024
…internationalization
Co-authored-by: Michael Lill <[email protected]> Co-authored-by: Fridtjof Siebert <[email protected]>
…internationalization
fridis
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add internationalization effect to format date based on location.