Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer install instructions using virtualenv, more convinient client_secrets.json location, Python3 support #294

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DougBeney
Copy link

This pull request:

  • Offers safer install instructions to use the package in a virtualenv. You should avoid using pip as sudo. (Everything still functions fine for those who do not want to use a virtualenv)
  • Offers an additional location for this script to look for client_secrets.json. It also looks in [PATH YOU INSTALLED YOUTUBE UPLOAD TO]/client_secrets.json
  • Fixes one error in Python3

@DougBeney DougBeney changed the title Safer install instruction, more convinient client secret location Safer install instructions using virtualenv, more convinient client secret location Apr 6, 2020
@DougBeney DougBeney changed the title Safer install instructions using virtualenv, more convinient client secret location Safer install instructions using virtualenv, more convinient client_secrets.json location Apr 6, 2020
@DougBeney DougBeney changed the title Safer install instructions using virtualenv, more convinient client_secrets.json location Safer install instructions using virtualenv, more convinient client_secrets.json location, Python3 support Apr 6, 2020
@kootsoop
Copy link
Collaborator

kootsoop commented May 6, 2020

@DougBeney Thanks for this! I'd prefer to keep both install instructions, rather than just the virtual env (which is a great addition!). Any comment?

@DougBeney
Copy link
Author

Yeah, that's fine. More options the merrier. Of course, it would be good to label one of the methods as "recommended" for those confused on which to go with.

@agiz
Copy link

agiz commented May 23, 2020

Disaster of a PR. Doesn't work, incomplete instructions /usr/local/Cellar/python/3.7.7/Frameworks/Python.framework/Versions/3.7/Resources/Python.app/Contents/MacOS/Python: can't open file '/Users/ziga/Documents/projects/youtube-tts/yt-upload-2/build/scripts-3.7/youtube-upload.py': [Errno 2] No such file or directory

@DougBeney
Copy link
Author

@agiz Disaster of a critique. You need to provide more info. Which command did you run that generated that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants