Answer:1 solution projection pre v16 #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luchillo17
reviewed
Nov 23, 2023
| }, | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| }) | ||
| export class CardComponent<T> { |
There was a problem hiding this comment.
May I ask how you tell T it has an id prop? using the @for loop now needs a track param, so this gives me an error:
There was a problem hiding this comment.
Normally I would tell T it expects an id prop like this, but then it breaks in the city card component:
export class CardComponent<T extends {id: string}> {
There was a problem hiding this comment.
Nevermind found my issue, id is a number, so the types were not overlapping...
| {{ name }} | ||
| <button (click)="delete(id)"> | ||
| <ng-content></ng-content> | ||
| <button (click)="delete.next()"> |
There was a problem hiding this comment.
Hey, I have a question, why did you use delete.next() instead of delete.emit(), Ive researched this and nextCall() seems to be deprecated
tomalaforge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for challenge submission