Change MainWindow to be a Gtk.Window instead of Gtk.Dialog #64

marcelobalexandre · 2019-07-04T19:50:26Z

Fix: #46

megatux

Code looks good to me. Also built it & installed and seems to work fine (ElementaryOS Juno, with i3 wm. I'm not sure why i3 still treats the window as a dialog but that seems to be unrelated)

marcelobalexandre · 2019-07-10T10:22:32Z

@megatux thanks for reviewing.

ryonakano

It looks like the layout changed between this branch and master.

ryonakano · 2019-07-17T13:36:31Z

src/Windows/MainWindow.vala

@@ -203,7 +207,7 @@ namespace Tomato.Window {
        private void setup_layout () {
            setup_headerbar ();
            setup_stack ();
-			content.add (slide);
+            content.pack_start (slide, false, false, 0);


Suggested change

content.pack_start (slide, false, false, 0);

content.add (slide);

marcelobalexandre mentioned this pull request Jul 4, 2019

Show the window in the multi-task view #46

Open

marcelobalexandre added 3 commits July 6, 2019 16:06

Change MainWindow to be a Gtk.Window instead of Gtk.Dialog

93f6a3a

Fix deprecation about icon-shadow property

634f9ba

Add Gtk.STYLE_CLASS_FLAT to the header

d625293

marcelobalexandre force-pushed the convert-dialog-into-window branch from 0c3ca80 to d625293 Compare July 6, 2019 19:07

marcelobalexandre marked this pull request as ready for review July 6, 2019 19:07

megatux approved these changes Jul 9, 2019

View reviewed changes

ryonakano reviewed Jul 17, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change MainWindow to be a Gtk.Window instead of Gtk.Dialog #64

Change MainWindow to be a Gtk.Window instead of Gtk.Dialog #64

marcelobalexandre commented Jul 4, 2019 •

edited

Loading

megatux left a comment

marcelobalexandre commented Jul 10, 2019

ryonakano left a comment •

edited

Loading

ryonakano Jul 17, 2019

	content.pack_start (slide, false, false, 0);
	content.add (slide);

Change MainWindow to be a Gtk.Window instead of Gtk.Dialog #64

Are you sure you want to change the base?

Change MainWindow to be a Gtk.Window instead of Gtk.Dialog #64

Conversation

marcelobalexandre commented Jul 4, 2019 • edited Loading

megatux left a comment

Choose a reason for hiding this comment

marcelobalexandre commented Jul 10, 2019

ryonakano left a comment • edited Loading

Choose a reason for hiding this comment

ryonakano Jul 17, 2019

Choose a reason for hiding this comment

marcelobalexandre commented Jul 4, 2019 •

edited

Loading

ryonakano left a comment •

edited

Loading