Three bug fixes #13
Merged
Three bug fixes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the serial goes above 07 to 08, it becomes an invalid number as it is interpreted as octal. Use the same trick as for the cert serial and force hex interpretation.
Certificates created with sign-csr might not have DNS SANs, which would lead to a crash ($san not set).
Server CSRs where handled the same as user CSRs: They were requested to provide an email. Instead ensure existence of the DNS SAN, or preserve the DNS SAN from the CSR.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the lst merge, got a few fixes that depended on the github actions as I added regression tests as part of the fixes.