Fix BZ 66331

Fix a regression in refactoring for Stack on the SystemLogHandler which caught incorrect exception.
tomitribe · Oct 25, 2023 · a905514 · a905514
1 parent 7f02284
commit a905514
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/java/org/apache/tomcat/util/log/SystemLogHandler.java b/java/org/apache/tomcat/util/log/SystemLogHandler.java
@@ -20,7 +20,7 @@
 import java.io.PrintStream;
 import java.util.ArrayDeque;
 import java.util.Deque;
-import java.util.EmptyStackException;
+import java.util.NoSuchElementException;
 import java.util.Queue;
 import java.util.concurrent.ConcurrentLinkedQueue;
 
@@ -83,7 +83,7 @@ public static void startCapture() {
         if (!reuse.isEmpty()) {
             try {
                 log = reuse.remove();
-            } catch (EmptyStackException e) {
+            } catch (NoSuchElementException e) {
                 log = new CaptureLog();
             }
         } else {

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
@@ -112,6 +112,11 @@
         use of fully qualified class names in 10.1.14 that broke the jdbc-pool.
         (markt)
       </fix>
+      <fix>
+        <bug>66331</bug>: Fix a regression in refactoring for <code>Stack</code>
+        on the <code>SystemLogHandler</code> which caught incorrect exception.
+        (lihan)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Other">